Make Discord RPC an optional dependency

[SyntaxNyah]

Discord RPC should be optional, not a forced dependency it's a feature most users disable anyway and adds unnecessary complexity for minimal benefit.

Consider offering separate builds (with/without Discord) or making it truly optional for users who want a minimal install. This could be addressed during the planned AO2 rework.

I was told to make this an issue by Wiso, so there you go.

#1131

[WisoAltred]

This feature is almost abandoned save for the fact that "discord", the checkbox, is on by default. If it was not, there is a good chance a good number of people would not even know it existed. Such a thing is hardly worth its place as a dependency and currently mostly serves to slightly annoy first-time builders of the AO-client who forget or don't know they should have had the .dll in place.

It is a minor gripe in the grand scheme of things though, and there probably are people out there who really want to use discord to show their courtroom or character and playtime.

If this is not outright removed in a future rework, perhaps making it optional in some form or putting it as its own separate build is an idea. It's alot to maintain, and at the moment I do not have a clean solution to offer that wouldn't drive the codebase further into random checks as is, but enough time has passed that this is a reasonable issue to be considered.

[Ganty1999]

even in readme it did says "discord-rpc (optional)".. it's good tho, but what syntaxnyah meant is about people using client from the official release one.. syntaxnyah want if one day you guys release new version.. let's make it discord-rpc are "optional".. (dynamic lib or whatever it calls)..

that's syntaxnyah's idea (and wishes) if one day.. an new version release..