Build Windows MSI artifacts from short dist path#93
Draft
gontzess wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The standard Go release workflow already enables Git long paths for Windows checkouts, but MSI generation can still fail before the workflow flattens files. GoReleaser Pro writes WiX source files under its dist directory using the public MSI name, and very long connector names can push that generated path beyond what WiX v3 handles.
This is a defensive parity change with the axiomatic workflow fix. It may be more conservative than strictly needed for standard Go connectors today, so this PR is draft for review.
What this changes
Points the Windows GoReleaser dist directory at a short runner-temp path while keeping the public ZIP and MSI filenames. After GoReleaser finishes, the workflow stages the public ZIP, MSI, signatures, and certificates back into the normal dist directory.
Windows SBOMs are generated after staging from the public filenames, then the existing provenance, SBOM attestation, upload, manifest, checksum, verification, and registry recording paths continue to read from the normal dist directory.
Validation
Not run locally: actionlint and pwsh were not installed. No test release was cut because there is not a known standard Go connector reproducer.