Record Go release metadata consistently#94
Merged
Conversation
3f250a3 to
e7328c7
Compare
kans
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Registry release records should capture the same release timestamp and changelog shape whether a connector release has a GitHub Release, an annotated tag, or only a tag. The standard Go workflow needs the manifest and registry API payload to agree on
released_atwhile still capturing the best changelog available.What this changes
Adds a release metadata helper that resolves changelog and timestamp from the GitHub Release first, then annotated tag metadata, then a generated commit list. The workflow uses one
released_atvalue for both manifest generation and the registry API payload.Companion change: the axiomatic workflow has the same expected registry behavior with workflow-specific plumbing. These PRs can merge independently after their connector test releases pass.
Validation
go test ./cmd/release-metadata ./cmd/record-release ./cmd/generate-manifestyq . .github/workflows/release.yamlgit diff --check origin/main...HEAD