Skip to content

chore: refresh Node 24 maintenance pass#248

Open
dex-the-ai wants to merge 5 commits into
masterfrom
deps/update-2026-06-09
Open

chore: refresh Node 24 maintenance pass#248
dex-the-ai wants to merge 5 commits into
masterfrom
deps/update-2026-06-09

Conversation

@dex-the-ai

@dex-the-ai dex-the-ai commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update the Node.js test workflow from Node 20 to Node 24
  • refresh the supportable patch-level Babel/Jest packages and regenerate package-lock.json
  • add QueryScanConsistency.RequestPlus to the airline/airport list handlers so the integration suite reliably sees newly inserted fixture documents on the current runtime/SDK stack

Verification

  • npm install
  • npm test ✅ (19/19 suites passed)
  • npm start
  • curl -I http://127.0.0.1:3000/
  • curl http://127.0.0.1:3000/api/v1/airline/airline_10

Evidence

  • Baseline verification on this sweep still had two red suites (api-airport-list, api-airline-list) after the env/bootstrap step; both were resolved by restoring request-plus consistency on the list queries.
  • Final passing logs are in tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/post-update-tests.txt.
  • Live walkthrough artifacts are in tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/walkthrough.txt, tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/screenshots/swagger-ui-home.png, and tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/videos/swagger-ui-walkthrough.webm.
  • npm audit is improved but not yet clean; the remaining 7 vulnerabilities are in the Express 4 / qs chain and the available fix path is larger than this maintenance pass.

Notes

  • I kept this PR to Node 24 CI alignment plus patch/minor dependency work; larger framework upgrades like Express 5 are still out of scope.

Media evidence

  • Auto-attached reviewer-facing media from the local verification artifacts captured during this run.
  • This keeps the main PR body self-contained instead of relying on a follow-up comment for visual proof.

Swagger Ui Home

Notes
  • Local artifact path: tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/screenshots/swagger-ui-home.png

Swagger Ui Walkthrough

Notes
  • Local artifact path: tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/videos/swagger-ui-walkthrough.webm

@dex-the-ai

Copy link
Copy Markdown
Contributor Author

Owner ping for this maintenance PR: @ejscribner @prajwal-pai77

Requesting review from the manifest-listed owner(s) where GitHub does not already show a pending review request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies in package.json and configures QueryScanConsistency.RequestPlus for Couchbase queries in both airlineController.js and airportController.js. The reviewer recommends making the scan consistency configurable via an environment variable rather than hardcoding it to RequestPlus, as doing so can cause performance bottlenecks and high latency in production environments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/controllers/airlineController.js
Comment thread src/controllers/airlineController.js
Comment thread src/controllers/airportController.js
Comment thread src/controllers/airportController.js

@ejscribner ejscribner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dex-the-ai do we need to add the scanConsistency to accommodate the dependency upgrades? Also, the test is failing.

Comment thread src/controllers/airlineController.js
Comment thread .github/workflows/tests.yaml Outdated
Comment thread src/controllers/airportController.js
Comment thread src/controllers/airportController.js
@dex-the-ai

Copy link
Copy Markdown
Contributor Author

Follow-up after rechecking this more carefully locally:

  • I pushed 3efd602 to restore QueryScanConsistency.RequestPlus on the two list endpoints.
  • After clearing stale local airport_test_* docs from my travel-sample bucket and rerunning the targeted list tests, both api-airline-list and api-airport-list failed immediately without the consistency override and passed again with it restored.
  • I then reran the full suite with npm run testGA; all 19 tests passed.
  • Because of that revert, the couchbase import in airportController is needed again.

So the current PR state keeps the Slack notifier v2 upgrade from f543460, but it also brings the list-query consistency change back because the local quickstart/test flow is still flaky without it.

GitHub checks are rerunning on this push now.

@dex-the-ai dex-the-ai requested a review from ejscribner June 9, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants