chore: refresh Node 24 maintenance pass#248
Conversation
|
Owner ping for this maintenance PR: @ejscribner @prajwal-pai77 Requesting review from the manifest-listed owner(s) where GitHub does not already show a pending review request. |
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies in package.json and configures QueryScanConsistency.RequestPlus for Couchbase queries in both airlineController.js and airportController.js. The reviewer recommends making the scan consistency configurable via an environment variable rather than hardcoding it to RequestPlus, as doing so can cause performance bottlenecks and high latency in production environments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
ejscribner
left a comment
There was a problem hiding this comment.
@dex-the-ai do we need to add the scanConsistency to accommodate the dependency upgrades? Also, the test is failing.
|
Follow-up after rechecking this more carefully locally:
So the current PR state keeps the Slack notifier v2 upgrade from GitHub checks are rerunning on this push now. |
Summary
package-lock.jsonQueryScanConsistency.RequestPlusto the airline/airport list handlers so the integration suite reliably sees newly inserted fixture documents on the current runtime/SDK stackVerification
npm installnpm test✅ (19/19suites passed)npm start✅curl -I http://127.0.0.1:3000/✅curl http://127.0.0.1:3000/api/v1/airline/airline_10✅Evidence
api-airport-list,api-airline-list) after the env/bootstrap step; both were resolved by restoring request-plus consistency on the list queries.tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/post-update-tests.txt.tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/walkthrough.txt,tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/screenshots/swagger-ui-home.png, andtutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/videos/swagger-ui-walkthrough.webm.npm auditis improved but not yet clean; the remaining 7 vulnerabilities are in the Express 4 /qschain and the available fix path is larger than this maintenance pass.Notes
Media evidence
Notes
tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/screenshots/swagger-ui-home.pngSwagger Ui Walkthrough
Notes
tutorial-maintenance/runs/nodejs-quickstart/2026-06-09T0319Z/videos/swagger-ui-walkthrough.webm