Skip to content

Commit d219361

Browse files
stephentoubCopilot
andcommitted
Stabilize unknown session delete E2E assertions
Assert the SDK-level delete failure prefix instead of the runtime-specific detail text so the tests pass against runtimes with different unknown-session wording. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent e8dabaf commit d219361

4 files changed

Lines changed: 14 additions & 9 deletions

File tree

dotnet/test/E2E/ClientSessionManagementE2ETests.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,11 @@ public async Task Should_Delete_Session_By_Id()
3535
public async Task Should_Report_Error_When_Deleting_Unknown_Session_Id()
3636
{
3737
await Client.StartAsync();
38+
const string UnknownSessionId = "00000000-0000-0000-0000-000000000000";
3839

3940
await AssertFailureAsync(
40-
() => Client.DeleteSessionAsync("00000000-0000-0000-0000-000000000000"),
41-
"Session file not found");
41+
() => Client.DeleteSessionAsync(UnknownSessionId),
42+
$"Failed to delete session {UnknownSessionId}");
4243
}
4344

4445
[Fact]

go/internal/e2e/client_api_e2e_test.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,14 @@ func TestClientApiE2E(t *testing.T) {
5050
})
5151

5252
t.Run("should report error when deleting unknown session id", func(t *testing.T) {
53-
err := client.DeleteSession(t.Context(), "00000000-0000-0000-0000-000000000000")
53+
sessionID := "00000000-0000-0000-0000-000000000000"
54+
err := client.DeleteSession(t.Context(), sessionID)
5455
if err == nil {
5556
t.Fatal("Expected DeleteSession to fail for unknown id")
5657
}
57-
if !strings.Contains(strings.ToLower(err.Error()), "session file not found") {
58-
t.Errorf("Expected error mentioning 'Session file not found', got %v", err)
58+
expectedMessage := "failed to delete session " + sessionID
59+
if !strings.Contains(strings.ToLower(err.Error()), expectedMessage) {
60+
t.Errorf("Expected error mentioning %q, got %v", expectedMessage, err)
5961
}
6062
})
6163

nodejs/test/e2e/client_api.e2e.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,11 @@ describe("Client session management", async () => {
3434

3535
it("should report error when deleting unknown session id", async () => {
3636
await client.start();
37+
const unknownSessionId = "00000000-0000-0000-0000-000000000000";
3738

3839
await assertFailure(
39-
() => client.deleteSession("00000000-0000-0000-0000-000000000000"),
40-
"Session file not found"
40+
() => client.deleteSession(unknownSessionId),
41+
`Failed to delete session ${unknownSessionId}`
4142
);
4243
});
4344

python/e2e/test_client_api_e2e.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,11 @@ async def test_should_delete_session_by_id(self, ctx: E2ETestContext):
3434

3535
async def test_should_report_error_when_deleting_unknown_session_id(self, ctx: E2ETestContext):
3636
await ctx.client.start()
37+
unknown_session_id = "00000000-0000-0000-0000-000000000000"
3738

3839
with pytest.raises(Exception) as exc_info:
39-
await ctx.client.delete_session("00000000-0000-0000-0000-000000000000")
40-
assert "session file not found" in str(exc_info.value).lower()
40+
await ctx.client.delete_session(unknown_session_id)
41+
assert f"failed to delete session {unknown_session_id}" in str(exc_info.value).lower()
4142

4243
async def test_should_get_null_last_session_id_before_any_sessions_exist(
4344
self, ctx: E2ETestContext

0 commit comments

Comments
 (0)