fix: Change the PageIterator logic to avoid making double calls on Current#9236
Open
Hectorhammett wants to merge 1 commit into
Open
fix: Change the PageIterator logic to avoid making double calls on Current#9236Hectorhammett wants to merge 1 commit into
Hectorhammett wants to merge 1 commit into
Conversation
Collaborator
Author
|
This aims to fix #9168 |
bshaffer
reviewed
Jun 8, 2026
Comment on lines
+196
to
+198
| if (!$this->isInitialized) { | ||
| $this->initialize(); | ||
| } |
Contributor
There was a problem hiding this comment.
nit but if(!$this->isInitialized) is redundant since we also check that in $this->initialize();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for PageIterator had a hidden bug:
The
PageIteratorimplements theIteratorclass and the usage of PHP iterator. If the user were to use thecurrentmethod on the iterator (eg:$rows->getIterator()->current()) the iterator would check if the first page was filled, if not it would perform an API call.The way it was setup, calling
currentwithout callingrewindwould always end up with an API call, meaning that in some cases the users would end up with a repeated API call even when the results where already in memory.This PR aims to fix that.