⚡ Bolt: Cache IconifyIcon resolution#44
Conversation
Co-authored-by: sshahriazz <34005640+sshahriazz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Implemented a Map cache (
iconCache) inIconifyIcon.tsxto memoize the resolution oficonDatafor both found and unfound icons.🎯 Why: Previously, the
iconDatafunction performed an O(N) array iteration over all imported icon sets for any prefix-less icon on every single render. This caused unnecessary synchronous CPU blocking and layout jank, especially when rendering lists or complex UIs with multiple icons in React 19 / MUI.📊 Impact: Reduces O(N) array iterations to an O(1) Map lookup on subsequent renders of any icon, significantly reducing component render time.
🔬 Measurement: Verify by rendering a view with multiple instances of prefix-less icons and observe reduced React render timings in the profiler. Unfound icons now fail fast by caching the negative
nullresult, preventing repeated iteration loops on missing icons.PR created automatically by Jules for task 6290027225951372913 started by @sshahriazz