Refactor native directory handling in Rapier3D#1016
Open
qurle wants to merge 1 commit into
Open
Conversation
It tries to place Rapier natives in `../.sable/` folder and fallbacks to user root directory (`%userprofile%/.sable` on Windows, `~/.sable/` on Mac or Linux)
Author
|
ARM Mac is fine. I’ll check x86 Windows by tomorrow. ARM Windows, x86 Mac and Linux are waiting to be tested. |
Collaborator
|
The better solution would be to use |
|
It works! Thanks qurle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured out that Rapier-related world join crashes on Apple Silicon Macs are caused by error in path resolving.
With this fix, Sable tries to place Rapier natives in
../.sable/folder and fallbacks to user root directory:%userprofile%/.sable/on Windows,~/.sable/on Mac and Linux.Now Sable works on my Mac M2 Pro (and all depending mods are working too).
That fix will likely close #743, close #864, close #947 and surely close #934.
Needs to be tested on other ARM and x86 machines
JAR: sable-neoforge-1.21.1-1.2.2.jar.zip