Improvements to Portal interactions with Sublevels#874
Draft
WeatheredCopperLantern wants to merge 4 commits into
Draft
Improvements to Portal interactions with Sublevels#874WeatheredCopperLantern wants to merge 4 commits into
WeatheredCopperLantern wants to merge 4 commits into
Conversation
…check the entities position or bounding box in .entityInside. For example the EndPortal. Also replace the transformInverse translation to get the local bounds, this fixes being able to trigger .entityInside through corners. For example entering a Nether portal if standing where a corner block would be.
… sublevels. - Patch EndPortalBlock.entityInside to work properly on rotated sublevels. - Allow NetherPortals on Sublevels to be choosen as exit targets
Author
|
Only took me 10 Days, but I finally have something to show.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to make portals play nicer with Sublevels.
WIP, but feel free to check commits and shout at me if I do something stupid or reinvent the wheel.