clean tokamax gmm and add test#4152
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
4 tasks
83c6449 to
eef262e
Compare
NuojCheng
reviewed
Jun 12, 2026
NuojCheng
approved these changes
Jun 12, 2026
c8af3f1 to
0ebbe64
Compare
khatwanimohit
approved these changes
Jun 12, 2026
parambole
approved these changes
Jun 12, 2026
88e561b to
f71379c
Compare
f71379c to
b88c6ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
manual_axis_typeconditional specification.use_tokamax_gmm=Truefor smoke train. Both bf16 and fp8.group offsetto None: PR#4082 addedgroup_offsettotokamax.ragged_dotandtokamax.ragged_dot_general. However,group_offsetis not yet supported by tokamax:Tests
unit test
tokamax_testTest on v5p-8: log
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.