Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
xibinliu
force-pushed
the
xibin/ci
branch
3 times, most recently
from
658e4a2 to
0acb622
Compare
xibinliu
requested review from
bvandermoon,
darisoy,
gobbleturk,
khatwanimohit,
parambole,
richjames0 and
shralex
as code owners
xibinliu
changed the title
shralex
reviewed
Jun 26, 2026
| fail-fast: false | ||
| matrix: | ||
| worker_group: ${{ fromJSON(contains(inputs.flavor, 'cpu-unit') && '[1, 2, 3, 4]' || '[1]') }} | ||
| worker_group: ${{ fromJSON(contains(inputs.flavor, 'cpu-unit') && '[1, 2, 3, 4]' || (inputs.flavor == 'tpu-unit' && '[1, 2]' || '[1]')) }} |
Collaborator
There was a problem hiding this comment.
lets use == also for cpu-unit for consistency
| maxtext_installed: ${{ inputs.maxtext_installed }} | ||
| worker_group: ${{ matrix.worker_group }} | ||
| total_workers: ${{ contains(inputs.flavor, 'cpu-unit') && 4 || 1 }} | ||
| total_workers: ${{ contains(inputs.flavor, 'cpu-unit') && 4 || (inputs.flavor == 'tpu-unit' && 2 || 1) }} |
Collaborator
There was a problem hiding this comment.
lets use == also for cpu-unit for consistency
| container_resource_option: "--privileged" | ||
| is_scheduled_run: ${{ github.event_name == 'schedule' }} | ||
| maxtext_sha: ${{ needs.build_and_upload_maxtext_package.outputs.maxtext_sha }} | ||
| total_workers: 2 |
Collaborator
There was a problem hiding this comment.
Lets define constants somewhere in one place and use them instead of literals
CPU worker constants
CPU_UNIT_TOTAL_WORKERS: 4
CPU_UNIT_WORKER_GROUPS: '[1, 2, 3, 4]'
TPU worker constants
TPU_UNIT_TOTAL_WORKERS: 2
TPU_UNIT_WORKER_GROUPS: '[1, 2]'
Default fallback constants
DEFAULT_TOTAL_WORKERS: 1
DEFAULT_WORKER_GROUPS: '[1]'
Collaborator
Author
There was a problem hiding this comment.
Use setup-parameters job to set up these constants.
TPU tests need to avoid spawning parallel xdist workers on the same TPU device
shralex
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split tpu-unit and pathways unit tests into 2 groups to speed up CI tests.
Tests
CI unit tests pass.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.