v4.2.8 — retry transient network errors (not just HTTP status codes)#88
Merged
Conversation
The retry path only retried HTTP statuses (429/5xx/529); a network error (timeout, connection reset, mid-flight drop — common on throttled endpoints like GLM) was classified Fatal and failed the turn outright. Add is_transient_error and, in the streaming request path (anthropic + openai-compatible/GLM), classify transient network errors as Retryable (synthetic 503) so they back off + retry like Claude Code. Real errors (bad key, model not found) still bail. Bumps 4.2.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LLM retry path only retried HTTP statuses (429/500/502/503/529). A bare network error — timeout, connection reset, mid-flight drop, common on throttled endpoints like GLM — was classified
Fataland failed the turn with no retry.Adds
retry::is_transient_errorand, in the streaming request path (anthropic + openai-compatible, which covers GLM), classifies transient network errors asRetryable(synthetic 503) so they back off + retry like Claude Code. Genuine errors (bad key, model-not-found, context-length) still bail immediately. Unit-tested; 34 retry tests pass. Bumps 4.2.8.