Skip to content

Adapt to rocq-prover/rocq#21987 (clear checks that ids are bound even when from match goal)#582

Closed
SkySkimmer wants to merge 1 commit intoAbsInt:masterfrom
SkySkimmer:context-secvar
Closed

Adapt to rocq-prover/rocq#21987 (clear checks that ids are bound even when from match goal)#582
SkySkimmer wants to merge 1 commit intoAbsInt:masterfrom
SkySkimmer:context-secvar

Conversation

@SkySkimmer
Copy link
Copy Markdown
Contributor

No description provided.

@xavierleroy
Copy link
Copy Markdown
Contributor

Thanks for the early notice and for the patch.

Just curious: the "clear" was to ensure that the same hypothesis is destructed at most once. If "clear" fails, what prevents the "repeat" to loop forever?

@SkySkimmer
Copy link
Copy Markdown
Contributor Author

SkySkimmer commented May 7, 2026

Nothing I guess, but it doesn't seem to happen in practice (see green CI).

AFAICT for it to loop H would need to be a section variable (otherwise destruct would clear it) and would need to appear in the goal (to make clear fail).

@xavierleroy
Copy link
Copy Markdown
Contributor

xavierleroy commented May 7, 2026

Gosh, you're right, destruct H already removes H, so clear H is useless. (Probably a leftover from an early version of this code that used elim instead of destruct.) I'll just remove clear H, then.

@SkySkimmer SkySkimmer deleted the context-secvar branch May 7, 2026 12:08
@xavierleroy
Copy link
Copy Markdown
Contributor

Works great without clear H (commit 2d1d75f). Thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants