DPL: fixes for memory leak in CCDB object caching#15386
Open
ehellbar wants to merge 2 commits intoAliceO2Group:devfrom
Open
DPL: fixes for memory leak in CCDB object caching#15386ehellbar wants to merge 2 commits intoAliceO2Group:devfrom
ehellbar wants to merge 2 commits intoAliceO2Group:devfrom
Conversation
ehellbar
changed the title
ehellbar
changed the title
ehellbar
changed the title
ehellbar
changed the title
ehellbar
changed the title
ktf
reviewed
May 10, 2026
| // every CCDB update from that point onwards. | ||
| auto oldDPLCacheIt = helper->mapURL2DPLCache.find(path); | ||
| auto cacheId = allocator.adoptContainer(output, std::move(v), DataAllocator::CacheStrategy::Always, header::gSerializationMethodCCDB); | ||
| if (oldDPLCacheIt != helper->mapURL2DPLCache.end()) { |
Member
There was a problem hiding this comment.
This seems to be a common pattern. Maybe worth a small helper?
Collaborator
Author
There was a problem hiding this comment.
maybe I can put the pruning inside the adoptContainer as you suggested in you former comment? this if (oldDPLCacheIt is anyway not really needed because the pruning is a no-op?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.