Fix link title double-quote escaping in inline links (#390)#443
Open
gaoflow wants to merge 1 commit into
Open
Conversation
When an HTML link title contains double-quote characters (e.g. decoded from "), the generated inline Markdown was invalid: [link](http://example.com "foo "bar" baz") The inner quotes break any CommonMark-compliant title parser. Fix by backslash-escaping double quotes inside the title string before wrapping it in the "…" delimiter inside link_url(). Adds a test fixture that exercises the broken case. Fixes Alir3z4#390
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an HTML link title contains double-quote characters (e.g. via the
"entity), the generated inline Markdown link is invalid:Produces:
The unescaped inner
"characters break CommonMark title parsing — the title ends at the first unescaped"after the opening one, leavingbar" baz"as stray text outside the link.Fix
Backslash-escape any
"characters in the title string before wrapping it in the"…"delimiter insidelink_url(). In CommonMark,\"inside a double-quoted title is a valid escape for a literal".After the fix:
Adds
test/link_title_with_quotes.{html,md}to the existing glob-driven test suite.Fixes #390
This pull request was prepared with the assistance of AI, under my direction and review.