Conversation
sproshev
approved these changes
Oct 15, 2016
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.io.OutputStream; | ||
|
|
There was a problem hiding this comment.
код не отформатирован, с модификаторами проблемы, сущности не упорядочены
-1
| } | ||
| root.deserialize(in); | ||
| return; | ||
| } |
There was a problem hiding this comment.
опять несодержательные return выражения
-0.5
| } | ||
| public int getCntNode() { | ||
| return root.getCntNode(); | ||
| } |
There was a problem hiding this comment.
код, используемый только в тестах, должен быть удален
тесты работают только с предоставляемым интерфейсом
|
|
||
| public class MyTree implements Trie, StreamSerializable{ | ||
| private class TreeNode { | ||
| final static String letters = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz!"; |
There was a problem hiding this comment.
именование констант
кстати, в других местах тоже именование хромает, но совсем чуть-чуть: getNumLet, passLet, вот это всё
| for (int i = 0; i < 52; i++) { | ||
| nextNode[i] = null; | ||
| } | ||
| } |
There was a problem hiding this comment.
52 -- magic number, для этого надо завести константу
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.