-
Notifications
You must be signed in to change notification settings - Fork 265
feat(rcv1p): unify cert bootstrap flow and add Windows CA refresh task #8096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ceebd22
57cd406
965f64f
7dba267
8b629de
394c3e0
1a3c77f
53abecc
d0bb7e6
be9ddef
4678c46
c0bec67
65924a2
133e6c6
c60e3c7
cf59a85
97c4f5c
d8dd1fb
e346cf9
ef80be3
084a5a5
ef89698
6da97f8
12bc156
180254e
2328667
e76bc3f
8780afe
9d1a2f1
fe84342
b6651ec
d9a4539
421fbe9
2f33739
bcfed44
82f2983
829218d
0ce609f
f1e42b6
c20ef57
0b1ed48
8d71344
374b84b
98eca0a
71a344b
016e8f9
5721d10
13f9833
38e4e6d
eb412d2
057a92b
fd6df99
9669db8
bf76e25
cdba52f
1bd253b
9c24851
3732a24
2af3e4c
9466de4
54ffb32
f0a1396
56bf65d
d5c4f5c
e335c3d
2b4d429
83ac070
63383eb
27d5086
9d0da88
4eb13f5
2d414ea
4353cd4
cadcff8
6b31a42
a5139fa
308eff9
fb8996b
46111f5
7b8b174
a12a0d8
8e1167c
f4965bb
708ca07
1fd6fef
54b48f3
dc3455a
01a4590
d36c6a4
9e34e6f
260f3c3
0c16a4d
9e172c8
d5108b9
db670a2
67e5645
2e68f4b
892116a
5ddbc1e
bba6793
f05669c
95a16c3
8b75bf9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| name: $(Date:yyyyMMdd)$(Rev:.r) | ||
| variables: | ||
| TAGS_TO_RUN: "rcv1pcertmode=true" | ||
| SKIP_E2E_TESTS: false | ||
| E2E_GO_TEST_TIMEOUT: "75m" | ||
| trigger: none | ||
| pr: none | ||
| jobs: | ||
| - template: ./templates/e2e-template.yaml | ||
| parameters: | ||
| name: RCV1P Cert Mode Tests | ||
| IgnoreScenariosWithMissingVhd: false | ||
| variableGroup: ab-e2e-tme-rcv1p | ||
| # The RCV1P testing subscription does not have platform auto-injection enabled, | ||
| # so the E2E framework explicitly injects opt-in tags on each VMSS. | ||
| rcv1pTagsAutoInjected: "false" | ||
|
rchincha marked this conversation as resolved.
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| echo $(date),$(hostname) > ${PROVISION_OUTPUT}; | ||
| {{if getIsAksCustomCloud .CustomCloudConfig}} | ||
| REPO_DEPOT_ENDPOINT="{{.CustomCloudConfig.RepoDepotEndpoint}}" | ||
| {{getInitAKSCustomCloudFilepath}} >> /var/log/azure/cluster-provision.log 2>&1; | ||
| {{end}} | ||
| LOCATION="{{getCloudLocation .}}" | ||
|
rchincha marked this conversation as resolved.
rchincha marked this conversation as resolved.
|
||
| {{getInitAKSCustomCloudFilepath}} >> /var/log/azure/cluster-provision.log 2>&1; | ||
|
rchincha marked this conversation as resolved.
rchincha marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should change the name of this template func: maybe
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was planning a follow up PR that cleans up references to "custom" after this PR lands. Also see my comment below. But ok either way. |
||
| /usr/bin/nohup /bin/bash -c "/bin/bash /opt/azure/containers/provision_start.sh" | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is going to monitor this pipeline and address any issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably include an explicit run of this pipeline within our daily build system we use for official releases, that way we're guaranteed to have visibility during official release flows
though at the end of the day it's going to be on us to deal with failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be enabled in the TME tenant and probably as a async nightly so that it doesn't interfere with "immediate" tests (PRs, etc)