[Foundry extensions] remove unnecessary approval workflows#8485
[Foundry extensions] remove unnecessary approval workflows#8485trangevi wants to merge 1 commit into
Conversation
Signed-off-by: trangevi <trangevi@microsoft.com>
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
There was a problem hiding this comment.
Pull request overview
Removes the per-extension required-approval GitHub Actions workflows for the Foundry-family azd extensions and folds the previously workflow-only approver lists into CODEOWNERS, so review enforcement is driven solely by GitHub's native code-owner approvals.
Changes:
- Deletes seven
approval-ext-azure-ai-*.ymlworkflows (agents, connections, inspector, projects, routines, skills, toolboxes). - Adds
@glharperto the Foundry-related extension entries in CODEOWNERS, and adds the inspector-specific approvers (@anchenyi @XiaofuHuang @swatDong) to the inspector entry. - Drops
@huimiufrom theazure.ai.projectsCODEOWNERS entry (appears unrelated to the stated PR purpose).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/approval-ext-azure-ai-agents.yml | Deleted approval gate workflow. |
| .github/workflows/approval-ext-azure-ai-connections.yml | Deleted approval gate workflow. |
| .github/workflows/approval-ext-azure-ai-inspector.yml | Deleted approval gate workflow (carried extra approver list). |
| .github/workflows/approval-ext-azure-ai-projects.yml | Deleted approval gate workflow. |
| .github/workflows/approval-ext-azure-ai-routines.yml | Deleted approval gate workflow. |
| .github/workflows/approval-ext-azure-ai-skills.yml | Deleted approval gate workflow. |
| .github/workflows/approval-ext-azure-ai-toolboxes.yml | Deleted approval gate workflow. |
| .github/CODEOWNERS | Adds @glharper (and inspector-specific reviewers) to Foundry extension ownership; removes @huimiu from projects. |
Additional notes (outside the diff):
.github/scripts/pr-approval-foundry-extensions-shared.jsis now orphaned — no remaining workflow references it. Consider removing it as a follow-up..github/skills/tool-version-upgrade/SKILL.mdstill citesapproval-ext-azure-ai-agents.ymlas an example of a supply-chain-hardened workflow; that reference is now stale.
JeffreyCA
left a comment
There was a problem hiding this comment.
There's a validation error at https://github.com/Azure/azure-dev/blob/trangevi/remove-foundry-workflows/.github/CODEOWNERS
May need to check @swatDong has proper access to the repo
Fixes #8484