Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

fix: show rename form as topbar popup#1679

Open
Isjuanplayer wants to merge 1 commit into
BoostIO:masterfrom
Isjuanplayer:issuehunt/boostnote-rename-popup
Open

fix: show rename form as topbar popup#1679
Isjuanplayer wants to merge 1 commit into
BoostIO:masterfrom
Isjuanplayer:issuehunt/boostnote-rename-popup

Conversation

@Isjuanplayer
Copy link
Copy Markdown

@Isjuanplayer Isjuanplayer commented May 11, 2026

Closes #1148

IssueHunt: https://oss.issuehunt.io/r/BoostIO/BoostNote-App/issues/1148

Summary

  • Open doc/folder rename forms from the topbar breadcrumb actions as small context popups anchored to the clicked action.
  • Remove the folder rename submit button, matching the issue request to save with Enter or by leaving the popup.
  • Save rename changes on Enter submit or when the input loses focus, with a guard to avoid duplicate saves when submit and blur happen back-to-back.

Verification

  • npx tsc --noEmit --pretty false
  • npx prettier --check src/cloud/lib/hooks/useCloudResourceModals.tsx src/cloud/lib/mappers/topbarBreadcrumbs.ts src/design/components/organisms/Topbar/atoms/TopbarActionItem.tsx src/design/components/organisms/Topbar/index.tsx
  • npx eslint src/cloud/lib/hooks/useCloudResourceModals.tsx src/cloud/lib/mappers/topbarBreadcrumbs.ts src/design/components/organisms/Topbar/atoms/TopbarActionItem.tsx src/design/components/organisms/Topbar/index.tsx --quiet

Note: npm run lint -- --quiet still reports pre-existing CRLF prettier errors in src/index.tsx, which this PR does not touch.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Isjuanplayer Isjuanplayer force-pushed the issuehunt/boostnote-rename-popup branch from 23012ac to 1e1bd7f Compare May 11, 2026 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve rename popup

2 participants