This repository was archived by the owner on May 12, 2026. It is now read-only.
Fix editor wheel scrolling over long wrapped lines#3792
Open
shriram-svg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2104.
Markdown edit mode can lose mouse-wheel scrolling when the wheel event starts over a long wrapped line, such as a fenced code block line over the reported threshold. This adds a small CodeMirror wheel fallback: after a wheel event, if the editor scroller did not move at all, it applies the normalized vertical wheel delta through
editor.scrollTo. Native/CodeMirror scrolling still wins whenever it handled the event.The browser-specific delta normalization is isolated in
browser/lib/wheelScroll.jsand covered with unit tests.Issue fixed
Type of changes
Verification
NODE_PATH=/Users/shriramvasudevan/worktrees/bounties/boostnote-2847/node_modules PATH=/Users/shriramvasudevan/worktrees/bounties/boostnote-2847/node_modules/.bin:$PATH jest tests/lib/wheel-scroll.test.js --runInBandNODE_PATH=/Users/shriramvasudevan/worktrees/bounties/boostnote-2847/node_modules PATH=/Users/shriramvasudevan/worktrees/bounties/boostnote-2847/node_modules/.bin:$PATH eslint browser/lib/wheelScroll.js browser/components/CodeEditor.js tests/lib/wheel-scroll.test.jsgit diff --checkyarn lintstill fails on the existing baseline, mostlystyleNamebeing reported as an unknown React property and unrelated Prettier findings.Checklist: