fix: 릴리즈 리뷰 반영 (pickup CLOSED·region 시드 정규화·keyword 경계 테스트)

[chanwoo7]

Summary

릴리즈 PR #148 봇 재리뷰에서 나온 valid 지적을 반영합니다(작은 fix).

변경 (반영)

• P2 (Codex) — pickupCalendar가 당일 모든 슬롯 마감 시(현재시각+리드타임 > 마지막 슬롯) selectable=false(CLOSED)로 처리. 캘린더는 선택 가능인데 시간 슬롯은 전부 마감인 dead-end 방지(pickupTimeSlots와 일치)
• regions.ts upsert 정규화 (CodeRabbit) — level1/level2 update에 level·parent_id 보정. 재시드 시 오염된 계층 데이터 정정
• keyword 경계 테스트 (CodeRabbit) — @MaxLength(80) 80통과/81거절 케이스 보강

보류 → 후속 이슈로 분리

• P1 region_id backfill (Codex) — 운영 기존 DB 배포 시 매장 region_id=NULL → 지역필터 popularStores 빈 결과. 개발 단계 무해(시드 매장은 region 연결됨, 배포 꺼짐). 운영 배포 전 처리(seller 매장 등록 시 region 연결 or backfill 마이그레이션) — 별도 이슈
• migration FK 락 분리 배포 (CodeRabbit) — 운영 데이터량에서 락 리스크. 운영 배포 시 단계적 적용

미반영 (오탐)

• 실DB 의존 spec 지적(CodeRabbit Major 4건) — 이 프로젝트는 createTestingModuleWithRealDb 기반 통합 테스트가 표준 컨벤션이라 의도된 패턴

Test plan

• yarn validate 통과 — 159 suites / 1344 tests / 커버리지 임계 충족

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ced30aed-129c-4456-a864-7a1824865ae3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/release-review-followups

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🩺 NestJS Doctor — 88/100 (Good)

진단 254건 (error 0).

Category	error	warning	info
architecture	0	0	13
correctness	0	105	0
performance	0	24	16
schema	0	0	83
security	0	13	0

architecture / security 상위 항목

• info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
• warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
• warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
• warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
• warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
• warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
• warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
• warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
• warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
• warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
• info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/conversation/repositories/conversation.repository'.
• info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'ConversationRepository'.
• info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/order/repositories/order.repository'.
• info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'OrderRepository'.
• info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/product/repositories/product.repository'.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

[github-actions]

🧹 knip — dead-code 리포트

요약 항목 없음

전체 리포트

(knip 출력 없음 — 이슈 0이거나 실행 실패)

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟢	Statements	97.42%	3886/3989
🟢	Branches	93.21%	1208/1296
🟢	Functions	94.64%	724/765
🟢	Lines	97.82%	3551/3630

Test suite run success

1344 tests passing in 159 suites.

Report generated by 🧪jest coverage report action from 334e8e6

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!