[pull] master from MusicPlayerDaemon:master#81
Merged
Conversation
Clients have no way of knowing which file in the song's directory was selected as the artwork. Exposing the path enables artwork comparison (do two tracks share artwork?), stable cache keys, detection of changes on disk, and clearer debugging when several candidate files are present. The path is resolved against the database (relative) URI for RELATIVE lookups and against the canonical URI for PATH/ABSOLUTE lookups, mirroring how the song was addressed by the client. Closes #2397
Don't leave outdated error messages in the player status when playback was resumed successfully. Closes #2454
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )