Manchester | 26-ITP-May | Abdu Hassen | Sprint 1 | Form Controls#1344
Open
Abduhasen wants to merge 3 commits into
Open
Manchester | 26-ITP-May | Abdu Hassen | Sprint 1 | Form Controls#1344Abduhasen wants to merge 3 commits into
Abduhasen wants to merge 3 commits into
Conversation
…elect for size choose,radio also for colour choose, used a lot <br> for spacing.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Abduhasen
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Abduhasen
added
the
Needs Review
Luro91
reviewed
May 24, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
How can you achieve a lighthouse score of 100?
| id="fname" | ||
| maxlength="10" | ||
| minlength="2" | ||
| pattern="[A-Za-z]+" |
There was a problem hiding this comment.
This does not allow special characters like the German ä,ü,ö
Author
There was a problem hiding this comment.
the pattern boundaries was too strict i didn't observe it they way you did.
Luro91
added
Reviewed
Abduhasen
added
Needs Review
Luro91
reviewed
May 25, 2026
| id="fname" | ||
| maxlength="10" | ||
| minlength="2" | ||
| pattern="^[\p{L}][\p{L}\s'-]*$" |
There was a problem hiding this comment.
I see an javascript error on the console:
Pattern attribute value ^[\p{L}][\p{L}\s'-]*$ is not a valid regular expression: Uncaught SyntaxError: Invalid regular expression: /^[\p{L}][\p{L}\s'-]*$/v: Invalid character in character class
Author
There was a problem hiding this comment.
i used another Unicode character range, more specifically a Latin Extended character class to fix the pattern attribute.
Luro91
added
Reviewed
Abduhasen
added
Needs Review
Luro91
reviewed
May 27, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done the code works as expected and easy to read.
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…elect for size choose,radio also for colour choose, used a lot
for spacing.
Learners, PR Template
Self checklist
Changelist
wrote a form control that takes first name, last name, email, colour and also size of a t-shirt i wrote form control using html
Questions
N/A