Skip to content

Feat/kms login#7

Draft
charming-wicket-5502 wants to merge 1 commit into
add_role_to_userfrom
feat/kms_login
Draft

Feat/kms login#7
charming-wicket-5502 wants to merge 1 commit into
add_role_to_userfrom
feat/kms_login

Conversation

@charming-wicket-5502

Copy link
Copy Markdown
Contributor

No description provided.

@charming-wicket-5502 charming-wicket-5502 changed the base branch from main to develop June 16, 2026 13:01
@Manuthor Manuthor changed the base branch from develop to add_role_to_user June 16, 2026 19:59
@Manuthor Manuthor requested a review from Copilot June 24, 2026 11:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a standard OIDC-style JWKS endpoint (/.well-known/jwks.json) so external services can discover the authentication server’s EC P-256 JWT signing public key, and updates API/docs accordingly.

Changes:

  • Introduces JWKS document generation from PEM (OpenSSL and rustls-only implementations) and exports it via the session module.
  • Adds a new unauthenticated GET /.well-known/jwks.json endpoint wired into the Actix app and OpenAPI schema.
  • Updates documentation references from the prior /public/jwks location to the new well-known location.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
server/src/session/mod.rs Re-exports JWKS-related types/helpers from the session JWT module.
server/src/session/jwt.rs Adds JWKS data type and PEM→JWKS builder implementations.
server/src/server/endpoints/mod.rs Exposes the new JWKS handler from the endpoints module.
server/src/server/endpoints/client_endpoints.rs Implements the jwks_well_known handler returning the prebuilt JWKS JSON.
server/src/server/auth_server.rs Builds JWKS once at startup, injects it into app data, and registers the /.well-known/jwks.json route.
server/documentation/openapi.yaml Updates the documented JWKS path and expands the response schema/example.
server/documentation/authorization_and_administration.md Updates endpoint listing to the new JWKS URL.
server/documentation/authentication_flows.md Updates flow diagrams/text to reference /.well-known/jwks.json.
server/documentation/api_reference.md Updates the API reference section header for the new JWKS endpoint.

Comment thread server/src/session/jwt.rs
.windows(2)
.enumerate()
.rev()
.find(|(i, w)| w[0] == 0x00 && w[1] == 0x04 && i + 2 + 64 <= der.len())
Comment on lines +309 to +313
.app_data(JsonConfig::default().limit(1_000_000))
.route(
"/.well-known/jwks.json",
web::get().to(jwks_well_known),
);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants