Feat/kms login#7
Draft
charming-wicket-5502 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a standard OIDC-style JWKS endpoint (/.well-known/jwks.json) so external services can discover the authentication server’s EC P-256 JWT signing public key, and updates API/docs accordingly.
Changes:
- Introduces JWKS document generation from PEM (OpenSSL and rustls-only implementations) and exports it via the session module.
- Adds a new unauthenticated
GET /.well-known/jwks.jsonendpoint wired into the Actix app and OpenAPI schema. - Updates documentation references from the prior
/public/jwkslocation to the new well-known location.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/session/mod.rs | Re-exports JWKS-related types/helpers from the session JWT module. |
| server/src/session/jwt.rs | Adds JWKS data type and PEM→JWKS builder implementations. |
| server/src/server/endpoints/mod.rs | Exposes the new JWKS handler from the endpoints module. |
| server/src/server/endpoints/client_endpoints.rs | Implements the jwks_well_known handler returning the prebuilt JWKS JSON. |
| server/src/server/auth_server.rs | Builds JWKS once at startup, injects it into app data, and registers the /.well-known/jwks.json route. |
| server/documentation/openapi.yaml | Updates the documented JWKS path and expands the response schema/example. |
| server/documentation/authorization_and_administration.md | Updates endpoint listing to the new JWKS URL. |
| server/documentation/authentication_flows.md | Updates flow diagrams/text to reference /.well-known/jwks.json. |
| server/documentation/api_reference.md | Updates the API reference section header for the new JWKS endpoint. |
| .windows(2) | ||
| .enumerate() | ||
| .rev() | ||
| .find(|(i, w)| w[0] == 0x00 && w[1] == 0x04 && i + 2 + 64 <= der.len()) |
Comment on lines
+309
to
+313
| .app_data(JsonConfig::default().limit(1_000_000)) | ||
| .route( | ||
| "/.well-known/jwks.json", | ||
| web::get().to(jwks_well_known), | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.