fix(directus): prevent email templates clipping on mobile#608
fix(directus): prevent email templates clipping on mobile#608dembrane-sam-bot wants to merge 1 commit into
Conversation
|
Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request. Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks! |
|
Warning Review limit reached
More reviews will be available in 15 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThree email templates (base, English, and Dutch notifications) are refactored to move outer padding from inline table styles to a dedicated outer-padding class on inner table cells, with corresponding media query updates ensuring responsive padding adjustments on mobile viewports. ChangesEmail template padding and responsive layout refactor
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cff55d4 to
8cd1e63
Compare
What this changes
Confidence: high. Standard email layout practice is to place padding on cells (
<td>) instead of the container<table>, which avoids WebKit viewport calculation bugs on responsive tables. Tested locally via inspection of the HTML layout tree.Refs: Slack message C0884QPQF6W-1780501376.541469
Summary by CodeRabbit