Skip to content

chore: update @disciple.tools/web-components to version 1.0.1#2925

Merged
corsacca merged 1 commit into
DiscipleTools:developfrom
cairocoder01:wc-v1-0-1
Jun 26, 2026
Merged

chore: update @disciple.tools/web-components to version 1.0.1#2925
corsacca merged 1 commit into
DiscipleTools:developfrom
cairocoder01:wc-v1-0-1

Conversation

@cairocoder01

Copy link
Copy Markdown
Collaborator

v1.0.1 — Patch Release

Bug Fixes

  • dt-location-map: Pin now tracks the map center as you pan instead of
    requiring a click to place. (dt-map-modal.js)
  • dt-location-map: canEdit now checks for metadata.lat, so a location
    with a label but no coordinates opens in editable state.
  • dt-location-map: Closing a read-only map no longer emits a submit event.
  • Google Geocoder: LatLng.lat()/lng() were called as properties, returning
    undefined on every geocoded result. Fixed. (componentService.js)
  • Google Geocoder: reverseGeocode() now uses the Maps JS SDK Geocoder
    instead of a direct REST fetch. getPlaceDetails() returns early when
    called without a place_id. (googleGeocodeService.js)

Improvements

  • dt-connection / dt-tags: Dropdown results are cached after the first
    fetch and filtered locally on reopen. Cache clears on query change.
  • dt-location-map: Support for selecting location on map and reverse geocoding

Developer Experience

  • dt-location-map: dt:geocode event is now observable in Storybook Actions.

@github-actions

Copy link
Copy Markdown

Code Review

No High or Medium severity findings.

Summary of changes reviewed

This PR bumps @disciple.tools/web-components from 1.0.0 → 1.0.1 and updates the three committed build artifacts (index.js, index.es.js, index.umd.cjs).

Correctness — The IIFE bundle (index.js) is self-contained and the only format the theme actually loads (via dt_theme_enqueue_script in enqueue-scripts.php, admin-enqueue-scripts.php, and dt-import-admin-tab.php). Its diff is consistent with the declared bug fixes (geocoder, map-pin tracking, canEdit check, close-event suppression). The export surface in index.es.js is unchanged (same 32 named exports).

Security — No new eval, innerHTML, untrusted fetch, or credential-handling patterns introduced in the bundle diff.

Package integritypackage-lock.json integrity hash updated to match the new registry entry; no transitive dependency changes.

Note (pre-existing, not introduced by this PR): index.es.js imports from a hashed chunk file (index-SpDyu9zt.js) that is not matched by the viteStaticCopy glob index.*js in vite.config.js, so it would not be copied at build time. Since the theme never loads the ES-module format, this has no runtime impact — but it is the same situation that existed for index-wqGuHN5u.js before this PR.

Ready to merge.

@corsacca corsacca merged commit 5086663 into DiscipleTools:develop Jun 26, 2026
3 checks passed
@corsacca

Copy link
Copy Markdown
Member

THanks @cairocoder01!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants