test: add confirmSliderThumb testID for maestro selectors#6042
Open
j0ntz wants to merge 1 commit into
Open
Conversation
Adds a stable testID to the SafeSlider thumb so automated UI flows can drive the confirm slider by id instead of brittle coordinate swipes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Adds a stable
testID="confirmSliderThumb"to theSafeSliderthumb so automated UI flows (maestro) can drive the confirm slider by id instead of brittle coordinate swipes. Test-infra only: no behavior or visual change. Snapshot files that renderSafeSliderare updated to include the new prop.Note
Low Risk
Test-only accessibility hook with no logic, styling, or transaction-flow changes.
Overview
Adds
testID="confirmSliderThumb"on theSafeSliderthumbAnimated.ViewinSafeSlider.tsxso Maestro (and similar automation) can target the slide-to-confirm control by id instead of coordinate swipes.Jest snapshots for screens/modals that render
SafeSliderare refreshed to include the new prop. No user-visible or runtime behavior change.Reviewed by Cursor Bugbot for commit 922c344. Bugbot is set up for automated code reviews on this repo. Configure here.