test(workflow-executor): PRD-552 legacy and deterministic Load Related Record coexist#1688
Conversation
… coexist (PRD-552) Explicit backward-compatibility regression: within one run, the same executor takes the AI path for a legacy prompt-only step (no preRecordedArgs) and the deterministic no-AI path for a step with source + relation pinned. fixes PRD-552 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
…ed' into feature/prd-552-backward-compat-load-related
| previousSteps: [makeLoadRelatedPreviousStep(1)], | ||
| stepDefinition: makeStep({ | ||
| executionType: StepExecutionMode.FullyAutomated, | ||
| preRecordedArgs: { selectedRecordStepId: 'load-1', relationName: 'customer' }, |
There was a problem hiding this comment.
non-blocking: selectedRecordStepId is not a recognized preRecordedArgs key (the schema/executor only accept selectedRecordStepIndex / selectedRecordIndex / relationName), so the source-record pinning this test sets up is silently ignored — selection falls back to all available records. The test passes only because relationName: 'customer' still pins the relation; it doesn't validate the step-index pinning its fixture implies. Use selectedRecordStepIndex: 1 (as in the existing deterministic test) to actually exercise it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 participant
Context
Joint backward-compat guard for the Deterministic Load Related Record epic (PRD-471), stacked on #1687 (PRD-551).
What
An explicit regression test: within one run the same executor takes the AI path for a legacy prompt-only step (no
preRecordedArgs) and the deterministic no-AI path for a step with source + relation pinned. Coexistence was already implied by the green suite; this names it as a guard.Where the rest of the coexistence is covered
forest:preRecordedArgs→ forwarded unchanged (parser test).guidancepanel (gating).Tests
82/82 in the load-related suite (run locally).
fixes PRD-552
🤖 Generated with Claude Code
Note
Add coexistence test for legacy and deterministic
LoadRelatedRecordStepExecutorpathsAdds a test suite in load-related-record-step-executor.test.ts verifying that legacy prompt-only
FullyAutomatedsteps callbindToolsfor AI relation selection, while deterministic steps withpreRecordedArgsand prior execution data skipbindToolsentirely and load related data directly.Macroscope summarized 7412b6a.