feat(workflow-executor): full-ai action forms, fill and submit with fallback (PRD-512)#1694
Open
Scra3 wants to merge 1 commit into
Open
Conversation
3 new issues
|
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (1)
🛟 Help
|
…allback (PRD-512) Full AI (FullyAutomated) on a form-bearing action now fills and submits the form automatically instead of throwing UnsupportedActionFormError. Reuses the shared fillFormWithAi loop from PRD-511, then: - all required fields filled -> executeOnExecutor submits the AI values (idempotency write-ahead) and records submissionOutcome 'executed' + submittedValues + the AI prefill (audit, PRD-513) - a required field left empty -> fall back to the exact AI-assisted review state, carrying what was filled - validation rejection / approval-required 403 -> same fallback (a human finishes natively); the fallback pause cleanly overwrites the 'executing' marker - plain permission 403 / infra error -> real step error (no fallback) Removes the UnsupportedActionFormError path for FullyAutomated + form. fixes PRD-512 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
f53a663 to
c12364a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Full AI mode of the action-forms epic (PRD-57), built on PRD-511. A
FullyAutomatedTrigger Action on a form-bearing action now fills + submits automatically instead of throwingUnsupportedActionFormError.Behaviour (reuses the shared
fillFormWithAiloop)executeOnExecutorsubmits the AI values (idempotency write-ahead executing→done) and recordssubmissionOutcome: 'executed'+submittedValues+ the AI prefill.ActionFormValidationError/ActionRequiresApprovalError) → same fallback; the fallback pause cleanly overwrites theexecutingmarker (no stuck-step on re-dispatch — asserted).Tests
1102 tests pass. New: fill+submit happy path (values asserted), fallback on incomplete / approval / validation (+ clean-marker assertion), plain-error → step error.
fixes PRD-512
Note
Add AI auto-fill and submit with fallback for FullyAutomated action form steps
TriggerRecordActionStepExecutor.doExecutenow runs AI fill (fillFormWithAi) for all form-bearing actions, includingFullyAutomatedmode, instead of throwing an unsupported error.FullyAutomatedsteps where the form is fully filled and executable, the executor callsexecuteOnExecutorto submit values automatically.ActionFormValidationErrororActionRequiresApprovalError, the step falls back to pausing for user review (awaiting-input) with AI-prefilled values.executeOnExecutornow accepts form payload and recordssubmissionOutcome,submittedValues, andaiFilledValuesin the step execution log.FullyAutomatedsteps with forms no longer error out; they either auto-submit or pause for input depending on fill completeness and submission outcome.Macroscope summarized c12364a.