refactor(agent-client): move test-only permission overrides to agent-testing

[Scra3]

Context

The permission-override mechanism on RemoteAgentClient — the overridePermissions field, the overrideCollectionPermission / overrideActionPermission / clearPermissionOverride methods, and the *PermissionsOverride types — is purely a test affordance. Its only consumer is agent-testing (sandbox + createAgentTestClient).

In production (mcp-server, workflow-executor) overridePermissions is always undefined, so these public methods are no-ops polluting the prod client API.

Change

Move the whole block to TestableAgentBase (agent-testing), its sole consumer:

• agent-client: remove the field, the 3 methods, the 3 types from RemoteAgentClient, and the dead overridePermissions param from createRemoteAgentClient (no caller — agent-testing uses new TestableAgentBase(...), not the factory).
• agent-testing: TestableAgentBase now owns overridePermissions + the override methods; the types live in a new permission-overrides.ts module, imported by forest-server-sandbox.ts and createAgentTestClient.
• Tests for the override methods moved from agent-client to a new agent-testing/test/testable-agent-base.test.ts.

Breaking change

@forestadmin/agent-client no longer exports the overridePermissions option of createRemoteAgentClient, nor the PermissionsOverride / CollectionPermissionsOverride / SmartActionPermissionsOverride types. These were test-only — consumers should use @forestadmin/agent-testing. No known production consumer used them (verified: only agent-testing imported them).

Tests

• agent-client: 317 pass (override tests removed).
• agent-testing: new testable-agent-base.test.ts 6 pass (moved override tests).
• Both build; mcp-server builds against the trimmed agent-client. Lint clean.

🤖 Generated with Claude Code

Note

Move permission override types and methods from agent-client to agent-testing

• Removes overrideCollectionPermission, overrideActionPermission, clearPermissionOverride, and related types from RemoteAgentClient in agent-client and its public exports.
• Moves these capabilities into a new TestableAgentBase subclass in agent-testing, which accepts an overridePermissions callback and re-implements the three override methods.
• Extracts the permission override types into a local permission-overrides.ts module so agent-testing no longer depends on agent-client for them.
• Risk: createRemoteAgentClient no longer accepts overridePermissions; callers relying on this parameter must switch to TestableAgentBase.

^{Macroscope summarized feaed65.}

[qltysh]

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

Rating	File	% Diff	Uncovered Line #s
	packages/agent-testing/src/testable-agent-base.ts	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.