Add a sparse bipermutedimsopadd! for TensorAlgebra 0.14#186
Merged
Conversation
Adds a `bipermutedimsopadd!` method for sparse destinations, so permutation and accumulation keep working after TensorAlgebra's `bipermutedimsopadd!` switched to a `StridedView`-based permute path that a sparse array cannot wrap. The accumulation reuses TensorAlgebra's logic over a lazily permuted source. Co-authored-by: Claude <noreply@anthropic.com>
`TensorAlgebra` is a weak dependency of SparseArraysBase, so Pkg rejects a `[sources]` entry for it in the root `Project.toml` (a source must reference a package in `[deps]` or `[extras]`). Move the branch pin to `test/Project.toml`, where `TensorAlgebra` is a regular test dependency and which is the only environment that needs the unreleased branch.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
- Coverage 77.57% 77.45% -0.13%
==========================================
Files 12 12
Lines 883 896 +13
==========================================
+ Hits 685 694 +9
- Misses 198 202 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TensorAlgebra 0.14 is registered, so the `[compat]` bound resolves against the release and the branch pin is no longer needed.
mtfishman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
bipermutedimsopadd!method for sparse destinations, so permutation and accumulation keep working after TensorAlgebra'sbipermutedimsopadd!switched to aStridedView-based permute path that a sparse array cannot wrap (ITensor/TensorAlgebra.jl#194). The accumulation reuses TensorAlgebra's logic over a lazily permuted source.