Don't log ignored errors unless debug logging is enabled#115
Open
bgilbert wants to merge 2 commits into
Open
Conversation
Avoid the dcm_error_newf() and dcm_error_free() if we won't log the message anyway.
Collaborator
Author
|
Even with this fix I think there's an API problem. If the DICOM file is corrupt, causing The but that's an API change and probably adds some duplicated code. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the
dcm_error_newf()anddcm_error_free()if we won't log the message anyway.With the current state of openslide/openslide#648, this avoids allocating, string-formatting, and freeing 690,658
dcm_filehandle_get_frame_number()errors when opening 3DHISTECH-2: