Configure PreloadsAppModules to be reusable#140
Merged
inxilpro merged 3 commits intoMay 21, 2026
Conversation
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
…h management to be shared Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Contributor
Author
|
Thanks for merging this in @inxilpro! Once a release is made here I'll open a PR to update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up
PreloadsAppModulesto be able to be reused in extending packages, such as https://github.com/InterNACHI/modular-livewire.Per InterNACHI/modular-livewire#2 (comment).
Slightly refactors
PreloadsAppModulesto be more usable by both packages. And exposes autoload of Concerns under tests so that it CAN be referenced.Though technically this pulls testing concerns into the final bundle, I think that is negligible and could actually be useful if downstream packages want to continue making their own plugins.
I also considered exposing / sharing
TestCaseas well. But going to hold to see if there is any interest.