Reorganize stdlib test overrides#2068
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make the overriding of CPython tests a bit simpler. This moves the
*_stdlib.pytests to astdlibfolder and drops the_stdlibsuffix. Also adjusts theCPythonCaseGeneratorto override CPython tests with the our override from thestdlibfolder. This means we no longer have ignore tests inCPythonCasesManifest.ini.To define stdlib overrides going forward, simply create the test file using
tests/suite/stdlib/gen_stdlib_test.py. The override will then run in place of the equivalent CPython test when runningmake.ps1 test. Test arguments can then be set in theCPythonCasesManifest.iniin place of the equivalent CPython test.