Propagate Connection Closure to Client#64
Open
crazyrokr wants to merge 3 commits intoJavaSaBr:developfrom
Open
Propagate Connection Closure to Client#64crazyrokr wants to merge 3 commits intoJavaSaBr:developfrom
crazyrokr wants to merge 3 commits intoJavaSaBr:developfrom
Conversation
JavaSaBr
reviewed
May 7, 2026
| protected void handleReceivedData(int receivedBytes, ByteBuffer readingBuffer) { | ||
| if (receivedBytes == -1) { | ||
| doHandshake(sslNetworkBuffer(), -1); | ||
| connection.close(); |
Owner
There was a problem hiding this comment.
it's not always about closing connection by my testing
Contributor
Author
There was a problem hiding this comment.
It's correct to close the connection in AbstractSslNetworkPacketReader when receivedBytes == -1.
In non-blocking I/O (which this library appears to use), a return value of -1 from a SocketChannel.read() call signifies that the connection has been gracefully closed by the remote peer (end-of-stream). If the local connection is not closed in response to this, it may leave the channel in an inconsistent or zombie state, potentially leading to resource leaks or repeated failed reads.
A test was added for this case: 6b19a97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the propagation of connection closures from the server to the client. Previously, clients might not have been correctly notified when a connection was closed by the server, potentially leading to stale connection states or unhandled exceptions in reactive streams.
Changes
ConnectionClosedExceptionto explicitly handle connection closure scenarios.AbstractConnectionto notify activeFluxSinksubscribers with aConnectionClosedExceptionwhen a connection is closed.AbstractNetworkPacketReaderandAbstractSslNetworkPacketReaderto correctly detect and report connection closures.ConnectionCloseTestto verify that the client correctly receives theConnectionClosedExceptionwhen a server connection is closed.