Skip to content

device-list and device-rename SDK#176

Open
mtyagi-ks wants to merge 3 commits into
device-management-new-commandsfrom
device-management-new-commands-int
Open

device-list and device-rename SDK#176
mtyagi-ks wants to merge 3 commits into
device-management-new-commandsfrom
device-management-new-commands-int

Conversation

@mtyagi-ks
Copy link
Copy Markdown

Summary

Add device-list and device-rename to keeper-sdk-python CLI, matching Commander’s user device management commands (admin commands deferred).

Changes

CLI (keepercli)

  • device-list — Lists the logged-in user’s devices via dm/device_user_list

    • Table output (default) with columns: id, name, client_type, login_status, last_accessed
    • Optional --format json and --output <file>
    • Devices sorted by last access (newest first); display id is 1-based for use with rename
  • device-rename — Renames a device via dm/device_user_rename

    • Target device: numeric id from device-list, or unique name substring
    • Input validation and name sanitization aligned with Commander
  • Registered under Account scope in register_commands.py (alongside this-device, login, etc.)

SDK (keepersdk)

  • Added DeviceManagement_pb2.py (generated protobuf) for device management REST request/response types

Tests & examples

  • Unit tests for API endpoint wiring, device resolution, and login validation
  • Example scripts: examples/cli_examples/device_management/device_list.py, device_rename.py

API flow

  1. Authenticated session (KeeperAuth.execute_auth_rest)
  2. dm/device_user_listDeviceUserResponse (list / resolve device)
  3. dm/device_user_renameDeviceRenameResponse (rename only)

Test plan

  • python -m unittest keepercli-package/unit_tests/test_device_management.py
  • Manual: device-list shows device table with real data
  • Manual: device-rename 1 "New Name" then device-list confirms rename

Copy link
Copy Markdown
Contributor

@adeshmukh-ks adeshmukh-ks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change examples from CLI to SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants