Support renew=true parameter for our CAS IdP#7674
Open
labkey-adam wants to merge 15 commits into
Open
Conversation
…arameter that's client-side only.
…Set session to re-auth user when current session is guest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Add a "force re-auth" mode to our standard login workflow. This mode requires the user to re-enter credentials, ignoring any existing login (i.e., current user session).
Summary of standard login changes:
forceReauth=trueparameter provided to the login action enables "force re-auth" mode.LoginUrls.getForceReauthURL()encapsulates the details for callers.LoginApiActiongenerates a secure token and stashes it & the re-auth user in session. It adds the token to the redirect URL asreauthToken=XXXXX. Any existing user session is left untouched.cas-login) should check the validity of the re-auth token (viaAuthenticationManager.getAndClearReauthUser()) to ensure re-auth took place immediately before action invocationUse by
cas-loginwithrenew=trueoptionrenew=trueLoginActionLoginAction.checkPermissions()override checks for the renew parameter. If not present, it proceeds normally (super.checkPermissions()).ServiceValidateActionis invoked with a ticket andrenewparameter, it returns an error if the ticket is not marked as "renew"Related Pull Requests
Largely Unrelated Changes
AssayIntegrationTestCase.jsppass on SQL Serverrememberparameter handlingViewContext.getRequestOrThrow()to reduce NPE warnings