Skip to content

Removing obsolete code that was hitting a deleted table#7688

Merged
labkey-klum merged 2 commits into
developfrom
fb_visualizationSQLGenerator_clean_up
May 25, 2026
Merged

Removing obsolete code that was hitting a deleted table#7688
labkey-klum merged 2 commits into
developfrom
fb_visualizationSQLGenerator_clean_up

Conversation

@labkey-klum
Copy link
Copy Markdown
Contributor

@labkey-klum labkey-klum commented May 22, 2026

Rationale

A claude code analysis revealed a usage that was not detected when we initially deleted the VisualizationVisitTag table. It was thought that there might be some reliance on that code in the CDS application but further analysis concluded that no test or product code from that application relies on this.

We can safely remove this (and related) code.

Tasks 📍

  • Claude Code Review

@labkey-klum labkey-klum self-assigned this May 25, 2026
@labkey-klum labkey-klum merged commit 503cd95 into develop May 25, 2026
9 checks passed
@labkey-klum labkey-klum deleted the fb_visualizationSQLGenerator_clean_up branch May 25, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants