Skip to content

fix(settings): always show language switch key when toggle is on #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfrvn wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −6
Open

fix(settings): always show language switch key when toggle is on #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions app/src/main/java/helium314/keyboard/latin/settings/SettingsValues.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,13 +460,10 @@ public boolean isLanguageSwitchKeyEnabled() {
if (!mShowsLanguageSwitchKey) {
return false;
}
// The behavior preference (mLanguageSwitchKeyToOtherImes / mLanguageSwitchKeyToOtherSubtypes)
// only controls what tapping the key does — it must not gate visibility, otherwise the
// toggle silently has no effect for users with a single enabled subtype (the common case).
final RichInputMethodManager imm = RichInputMethodManager.getInstance();
if (!mLanguageSwitchKeyToOtherSubtypes) {
return imm.hasMultipleEnabledIMEsOrSubtypes(false /* include aux subtypes */);
}
if (!mLanguageSwitchKeyToOtherImes) {
return imm.hasMultipleEnabledSubtypesInThisIme(false /* include aux subtypes */);
}
return imm.hasMultipleEnabledSubtypesInThisIme(false /* include aux subtypes */)
|| imm.hasMultipleEnabledIMEsOrSubtypes(false /* include aux subtypes */);
}
Expand Down