Prevent propagating focus to readonly form editors - fix iOS crashing#4561
Open
tomasMizera wants to merge 1 commit into
Open
Prevent propagating focus to readonly form editors - fix iOS crashing#4561tomasMizera wants to merge 1 commit into
tomasMizera wants to merge 1 commit into
Conversation
tomasMizera
force-pushed
the
fix/drawers-crash-ios
branch
from
9e6925f to
a603a89
Compare
Coverage Report for CI Build 28168770527Warning No base build found for commit Coverage: 59.03%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the crash mentioned here https://github.com/MerginMaps/releases/issues/147#issuecomment-4779566892 (problem num. 2)
This seems to be a Qt bug and will be reported.
Looks like a dangling pointer when combining
QIOSTapRecognizerand drawers. The fix is to not accept focus forreadonlyform items (which is a correct step regardless the crash).As a side effect, this #4522 now results in even worse UX, so I will fix it in a standalone PR and we add it to the release.