fix(web): keep plan review pending in yolo mode#920
Conversation
🦋 Changeset detectedLatest commit: a20b78c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a20b78c022
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| function shouldAutoApproveApproval(approval: AppApprovalRequest, mode: PermissionMode): boolean { | ||
| if (mode === 'auto') return true; | ||
| if (mode === 'yolo') return !isPlanReviewApproval(approval); |
There was a problem hiding this comment.
Prevent session-scoped approvals for YOLO plan reviews
When a YOLO ExitPlanMode/plan_review request reaches this branch, it is no longer auto-approved and is rendered through the existing generic ApprovalCard. That card always offers “Approve for this session” and respondApproval forwards scope: 'session'; choosing it records a session-scoped ExitPlanMode approval, so later plan exits in the same session can bypass explicit review instead of using the TUI-style plan-review choices. Please add a plan-review-specific pending approval path or suppress the session-scoped action for these requests.
Useful? React with 👍 / 👎.
Related Issue
Resolve #870
Problem
See linked issue.
What changed
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.