fix(agent-core): add schema hints to tool arg errors#923
Open
tt-a1i wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 089d415 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #819
Problem
Tool argument validation errors currently say which argument is wrong, but not which names or types the model should use instead.
What changed
Validation
pnpm --filter @moonshot-ai/agent-core exec vitest run test/tools/input-schema-io.test.tspnpm --filter @moonshot-ai/agent-core run testpnpm --filter @moonshot-ai/agent-core run typecheckpnpm exec oxlint --type-aware packages/agent-core/src/tools/args-validator.ts packages/agent-core/test/tools/input-schema-io.test.ts --quietpnpm --filter @moonshot-ai/agent-core run buildgit diff --checkChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.AI Assistance Disclosure
I used Codex to review the changes, sanity-check the implementation against existing patterns, and help spot potential edge cases.