Skip to content

Add target-specific QRF fit filters#190

Merged
MaxGhenis merged 1 commit into
mainfrom
target-filters
May 21, 2026
Merged

Add target-specific QRF fit filters#190
MaxGhenis merged 1 commit into
mainfrom
target-filters

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

Summary

  • add common row_filter and per-target target_filters to imputer fitting
  • make QRF train each target on its own eligible rows, including max_train_samples after target filtering
  • add regression tests for row filters, target filters, unknown target filters, and target filtering with max_train_samples

Tests

  • env -u UV_FROZEN uv lock --check
  • env -u UV_FROZEN uv run --python 3.13 ruff check microimpute/models/imputer.py microimpute/models/qrf.py
  • env -u UV_FROZEN uv run --python 3.13 --extra dev python -m pytest tests/test_models/test_qrf.py -q

Python 3.14 dependency support is intentionally excluded and will be handled in a separate PR.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
microimpute-dashboard Ready Ready Preview, Comment May 21, 2026 5:42pm

@MaxGhenis MaxGhenis merged commit dfb9982 into main May 21, 2026
7 checks passed
@MaxGhenis MaxGhenis deleted the target-filters branch May 21, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant