feat: add additional data support for particles on Minestom platform#561
Open
Sybsuper wants to merge 1 commit into
Open
feat: add additional data support for particles on Minestom platform#561Sybsuper wants to merge 1 commit into
Sybsuper wants to merge 1 commit into
Conversation
Bloeckchengrafik
approved these changes
May 16, 2026
Bloeckchengrafik
left a comment
Member
There was a problem hiding this comment.
Thanks for looking into this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR adds support for additional data for biome ambient particles on the Minestom platform.
The problem
When attempting to load particles such as:
On the Minestom platform this would ignore the particle with a warning in the console:
Why?
This behavior is actually very understandable, since Minestom until recently didn't have a Particle Codec to decode Particles from a string. Implementing the parsing manually would have been very painful.
The solution
Recently, Minestom has added decoding capabilities to their Particle Codec Minestom/Minestom@920922c. This allows us to easily implement a parser using their decoder.
Changelog
BiomeParticleConfigTemplate.javafile and added parsing for additional particle dataNOTE: When making this change I found that Minestom currently has a bug in their Particle Codec that doesn't correctly parse
block_statevalues. I've made a PR Minestom/Minestom#3175 to Minestom to fix this. Until then it does correctly parse particle data that has no block states. When this PR is merged, no code changes should be required (fingers crossed) to accommodateblock_statevalues.I've kept the past behavior of ignoring a particle completely when it cannot be parsed correctly and send a warning in the console.
An example of such a warning:
Checklist
Mandatory checks
ver/prefix)or is a branch that is intended to be merged into a version branch.
CONTRIBUTING.mddocument in the root of the git repository.
Types of changes
Compatibility
Documentation
Testing
This PR can be tested by launching a Minestom server with Terra (such as the example server in this repo). The most easy to locate place the newly supported particles can observed is in the end dimension with the end dimension's default pack.
javaw_SceTe5ExSp.mp4
Change the following code in
TerraMinestomExample.javato load the end pack on Minestom.Then simply run the example server and join it.
NOTE: There will be some warnings in the console for particles with
block_state. See the note above for an explanation and an example of such a warning.Licensing
release it under GPLv3.
released under GPLv3 or a compatible license.