feat: Add session support for mcp#17
Open
jawad-khan wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds session-based authentication support to the public v1 API layer by updating the shared base API view classes to accept session cookies in addition to API keys.
Changes:
- Add
BaseSessionAuthenticationtoBaseAPIView.authentication_classes - Add
BaseSessionAuthenticationtoBaseViewSet.authentication_classes
Comment on lines
51
to
53
| class BaseAPIView(TimezoneMixin, GenericAPIView, ReadReplicaControlMixin, BasePaginator): | ||
| authentication_classes = [APIKeyAuthentication] | ||
| authentication_classes = [BaseSessionAuthentication, APIKeyAuthentication] | ||
|
|
Comment on lines
168
to
172
| class BaseViewSet(TimezoneMixin, ReadReplicaControlMixin, ModelViewSet, BasePaginator): | ||
| model = None | ||
|
|
||
| authentication_classes = [APIKeyAuthentication] | ||
| authentication_classes = [BaseSessionAuthentication, APIKeyAuthentication] | ||
| permission_classes = [ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References