Skip to content

feat(cluster-creation): add explicit CPU architecture for GCP#2723

Draft
TheoGrandin74 wants to merge 2 commits into
stagingfrom
feat/GKE-explicit-architecture
Draft

feat(cluster-creation): add explicit CPU architecture for GCP#2723
TheoGrandin74 wants to merge 2 commits into
stagingfrom
feat/GKE-explicit-architecture

Conversation

@TheoGrandin74

@TheoGrandin74 TheoGrandin74 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Add explicit CPU architecture handling for GCP workloads and cluster creation:

  • indicate ARM support on GCP regions during cluster creation
  • expose CPU architecture selection in service resources when the GCP region supports ARM
  • send cpu_architecture on service create/edit payloads, mapping DEFAULT to null

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.70%. Comparing base (0e55957) to head (3a2b877).
⚠️ Report is 13 commits behind head on staging.

Files with missing lines Patch % Lines
...tings-resources/application-settings-resources.tsx 0.00% 9 Missing ⚠️
...vices/src/lib/cpu-architecture/cpu-architecture.ts 0.00% 4 Missing ⚠️
...luster-creation-flow/step-general/step-general.tsx 70.00% 2 Missing and 1 partial ⚠️
libs/shared/util-services/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2723      +/-   ##
===========================================
+ Coverage    45.22%   46.70%   +1.47%     
===========================================
  Files         1139     1143       +4     
  Lines        23934    24047     +113     
  Branches      6993     7107     +114     
===========================================
+ Hits         10825    11232     +407     
+ Misses       11234    10833     -401     
- Partials      1875     1982     +107     
Flag Coverage Δ
unittests 46.70% <32.00%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant