fix(secret-manager): UI fixes#2747
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies UI/UX fixes around external secrets creation and toast/modal interactions, improving reliability when secret-manager provider lookups fail and preventing modals from being unintentionally dismissed during toast interactions.
Changes:
- Ensure toasts render above overlays/modals and prevent toast interactions from triggering modal “outside click” behavior.
- Pass
scopeinto the external secret creation modal and add an environment-scope acknowledgement step. - Improve resilience of provider secret reference lookup (disable retries, fallback to manual reference input on error) and add tests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/shared/ui/src/lib/components/toast/toast.tsx | Adds z-toast to ensure toast z-index stacks above modal/overlay and to support toast interaction detection. |
| libs/shared/ui/src/lib/components/modal/modal.tsx | Prevents toast interactions from being treated as outside-modal interactions. |
| libs/domains/variables/feature/src/lib/external-secrets/external-secrets-tab.tsx | Passes scope into AddSecretModal and updates hook dependencies accordingly. |
| libs/domains/variables/feature/src/lib/external-secrets/external-secrets-tab.spec.tsx | Adds assertions/tests ensuring scope is passed through to the modal for different scopes. |
| libs/domains/variables/feature/src/lib/external-secrets/add-secret-modal/add-secret-modal.tsx | Adds environment-level cost acknowledgement UI + fallback to text reference input when provider secrets fail; disables query retries. |
| libs/domains/variables/feature/src/lib/external-secrets/add-secret-modal/add-secret-modal.spec.tsx | New tests covering retry disabling, fallback input rendering, and acknowledgement gating. |
| libs/domains/clusters/feature/src/lib/hooks/use-secret-manager-provider-secrets/use-secret-manager-provider-secrets.ts | Exposes retry option to control React Query retry behavior from callers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2747 +/- ##
===========================================
- Coverage 46.16% 46.00% -0.17%
===========================================
Files 1208 1129 -79
Lines 25695 24489 -1206
Branches 7572 7292 -280
===========================================
- Hits 11863 11267 -596
+ Misses 11761 11252 -509
+ Partials 2071 1970 -101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 1.315.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Issue: This PR introduces a few UI improvements for the Secret Manager feature.
Changes:
isToastInteractionhelper has been added to detect whether the toast has been clicked or not.Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release