slave node design#148
Open
syntrust wants to merge 2 commits into
Open
Conversation
syntrust
requested review from
blockchaindevsh,
iteyelmp,
ping-ke,
qizhou and
qzhodl
|
|
||
| ## Architecture overview | ||
|
|
||
| All code lands under new packages; no geth source file is modified, per the project rule |
Collaborator
There was a problem hiding this comment.
I think it's not accurate, we'll modify in-place the geth modules that take interface as parameter(if possible), but will modify out-place those that take concrete types.
| goquarkchain/pyquarkchain config divergences are immaterial here: the WebSocket RPC port | ||
| (singular nullable `WEBSOCKET_JSON_RPC_PORT` in pyquarkchain | ||
| ([`cluster_config.py:91`](https://github.com/QuarkChain/pyquarkchain/blob/master/quarkchain/cluster/cluster_config.py#L91)) | ||
| vs array `WEBSOCKET_JSON_RPC_PORT_LIST` in the existing config) is never read. |
Collaborator
There was a problem hiding this comment.
WEBSOCKET_JSON_RPC_PORT_LIST will be gone after merging QuarkChain/goshard#16
| | Unknown `--node_id` | `ResolveSlave` | Exit non-zero: `unknown node id "S9" (config defines: S0)`. | | ||
| | Shard id not in any chain | `Validate()` | Reject at load, before any db opens. | | ||
| | Duplicate shard ownership | `Validate()` | Reject at load. | | ||
| | Legacy `CHAIN_MASK_LIST` | parse | Explicit "legacy config not supported". | |
Collaborator
There was a problem hiding this comment.
QuarkChain/goshard#16 is still supporting CHAIN_MASK_LIST, have we reached consensus about dropping it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking QuarkChain/goshard#17