Skip to content

Added support for promptEnhancement#304

Open
Sirsho1997 wants to merge 2 commits into
mainfrom
feature-ernie
Open

Added support for promptEnhancement#304
Sirsho1997 wants to merge 2 commits into
mainfrom
feature-ernie

Conversation

@Sirsho1997
Copy link
Copy Markdown
Collaborator

Added

IPromptEnhancement dataclass for nested settings.promptEnhancement:

  • enabled: Optional[bool]
  • temperature: Optional[float]
  • topP: Optional[float]

@Sirsho1997 Sirsho1997 requested a review from Copilot June 2, 2026 16:38
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cf98d26c-f637-42e2-a566-7488a6804064

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature-ernie

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new nested settings shape for settings.promptEnhancement by introducing an IPromptEnhancement dataclass and wiring dict-to-dataclass coercion in ISettings.__post_init__.

Changes:

  • Added IPromptEnhancement dataclass (enabled, temperature, topP) for nested prompt enhancement settings.
  • Added ISettings.promptEnhancement field (supports IPromptEnhancement, dict, or bool) and coerces dict inputs to IPromptEnhancement in __post_init__.
  • Removed ISettings.promptUpsampling (backward-incompatible; see review comments).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread runware/types.py
Comment thread runware/types.py
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread runware/types.py
Comment on lines +1152 to +1153
if isinstance(self.promptEnhancement, dict):
self.promptEnhancement = IPromptEnhancement(**self.promptEnhancement)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants