WireMod for SBND Gen 2 Production#649
Open
tbwester wants to merge 10 commits intoproduction/sbnd-gen2from
Open
WireMod for SBND Gen 2 Production#649tbwester wants to merge 10 commits intoproduction/sbnd-gen2from
tbwester wants to merge 10 commits intoproduction/sbnd-gen2from
Conversation
hausnerh
reviewed
May 8, 2026
| raw::ChannelID_t channel = sc->Channel(); | ||
| std::vector<geo::WireID> maybewire = wireReadout.ChannelToWire(channel); | ||
| geo::WireID thisWire; // Default constructor makes invalid wire | ||
| if (maybewire.size()) thisWire = maybewire[0]; |
Contributor
There was a problem hiding this comment.
How does this handle when ChannelToWire returns multiple WireIDs? This can happen near the middle of ICARUS where the wire geometry is split into two "logical" TPC for North and South and the wires crossing there get split into two WireIDs despite reading out from the same channel. See chapter 5 here for some details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add WireMod utility functions for SBND Gen 2. This also brings in refactor of RecoUtils. The WireMod utility should be identical to the SBND Gen 1 production based on v10_06_00_10. Develop PR to follow.